RFR: 8253639: Change os::attempt_reserve_memory_at parameter order

Stefan Karlsson stefank at openjdk.java.net
Fri Sep 25 14:14:45 UTC 2020


On Fri, 25 Sep 2020 13:57:38 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Looks good to me.
>> 
>> I still learn to skara and just noticed that as a reviewer I cannot use /reviewer. Since this PR contains commits from
>> some other PR, I don't know how to mark this as reviewed.
>
> Thanks Thomas. You need to click "Files changed" then "Review Changes" to review this. I don't think there's a
> /reviewer command you can use. I'll ask.

Currently, the `/reviewer` command is only there to the PR owner to credit additional reviewers. I've created a Skara
ticket asking if this could be enhanced: https://bugs.openjdk.java.net/browse/SKARA-736

-------------

PR: https://git.openjdk.java.net/jdk/pull/359


More information about the hotspot-dev mailing list