RFR: 8253639: Change os::attempt_reserve_memory_at parameter order

Ioi Lam iklam at openjdk.java.net
Fri Sep 25 19:06:16 UTC 2020


On Fri, 25 Sep 2020 15:07:54 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> I propose that we change the parameter order from:
>> os::attempt_reserve_memory_at(size, addr, <extra params>)
>> 
>> to:
>> os::attempt_reserve_memory_at(addr, size, <extra params>)
>> 
>> This patch builds upon the changes in pull/357. There's currently no way to create an incremental review, but I want to
>> get this out for review now. So, unfortunately you have to ignore the first commit and look at the second commit.
>
> Parameter reordering looks good.

Could you add an explanation in the bug report for the reason of this change?

-------------

PR: https://git.openjdk.java.net/jdk/pull/359


More information about the hotspot-dev mailing list