RFR: 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function [v2]

Coleen Phillimore coleenp at openjdk.java.net
Fri Sep 25 22:55:11 UTC 2020


On Thu, 24 Sep 2020 15:54:33 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2106:
> 
>> 2104: JRT_LEAF(void, SharedRuntime::complete_monitor_unlocking_C(oopDesc* obj, BasicLock* lock, JavaThread* thread))
>> 2105:   // The object could become unlocked through a JNI call, which we have no other checks for.
>> 2106:   // Give a message if CheckJNICalls but ignore.
> 
> That comment is a bit misleading. Perhaps:
> // Give a fatal message if CheckJNICalls. Otherwise we ignore it.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/320


More information about the hotspot-dev mailing list