RFR: 8253402: Convert vmSymbols::SID to enum class [v2]

[Ioi Lam]

On Fri, 25 Sep 2020 22:46:20 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes
>> the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last
>> revision:
>>  - more vmEnums.hpp fixes; fixed minimal VM build
>>  - Merge branch 'master' into 8253402-convert-vmsymbols-sid-to-enum-class
>>  - Moved forward declaration of vmSymbolID to vmEnums.hpp
>>  - clean up whitespaces and removed useless comment
>>  - removed unnecessary include
>>  - 8253402: Convert vmSymbols::SID to enum class
>
> src/hotspot/share/utilities/vmEnums.hpp line 33:
> 
>> 31:
>> 32: enum JVMFlagsEnum : int;
>> 33: enum class vmSymbolID : int;
> 
> I don't like that you mixed two different enums that are used in different places here.  Can you go back?

The intention is to put other enums like vmIntrinsics::ID and SystemDictionary::WKID here. It's going to be a small
collection of "enums used by the VM that have complex definitions but you probably don't care".

-------------

PR: https://git.openjdk.java.net/jdk/pull/276