RFR: 8253540: InterpreterRuntime::monitorexit should be a JRT_LEAF function [v3]

Martin Doerr mdoerr at openjdk.java.net
Mon Sep 28 09:33:50 UTC 2020


On Fri, 25 Sep 2020 22:15:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> That the monitor has already been unlocked, or is a null stacklock monitor has been already checked in the caller, so
>> the code that makes it a JRT_ENTRY_NO_ASYNC is unnecessary.
>> Making it a JRT_LEAF like the compiled method entries makes it safer. We know it can never safepoint and
>> unintentionally install a async exception.
>> Tested with tier1-6.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   make calls through call_VM_leaf

Thanks for taking care of all platforms. Looks good.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/320


More information about the hotspot-dev mailing list