RFR: 8253015: Aarch64: Move linux code out from generic CPU feature detection
Anton Kozlov
akozlov at azul.com
Mon Sep 28 11:31:06 UTC 2020
Hello Andrew,
On 25.09.2020 15:45, Andrew Haley wrote:
> On 24/09/2020 18:10, Ludovic Henry wrote:
>> A quick follow-up on getting a review for this patch. We're starting to take dependency on this patch for the
>> Windows-AArch64 and macOS-AArch64
>> (https://github.com/openjdk/jdk/pull/212/commits/7bf0aab32fb7ef1659efa09651d59aaed53c31d2). /cc @theRealAph
>
> It's a large and complex patch.
>
> It looks OK, so I have read through and reviewed it, but I haven't tested
> it on Linux-AArch64. I assume you've done that.
>
Sorry, do you refer to JDK-8248238 (Implementation of JEP: Windows AArch64) or
to JDK-8253015 (Aarch64: Move linux code out from generic CPU feature
detection)? Because first one was reviewed, but the second one (that is
included in the former) was not.
The intention of this CPU feature detection patch is to do a preparation and
make Windows/AArch64 patch more simple for review.
Could you and community review this (cpu feature detection) patch as well?
Thanks,
Anton
More information about the hotspot-dev
mailing list