RFR: 8253640: Make MEMFLAGS an enum class [v2]

Stefan Karlsson stefank at openjdk.java.net
Mon Sep 28 13:00:11 UTC 2020


On Mon, 28 Sep 2020 12:40:43 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review 1
>
> src/hotspot/share/services/nmtCommon.hpp line 55:
> 
>> 53:   }
>> 54:
>> 55:   // Check if flag value is a valid MEMFLAGS enum value
> 
> Small nit, can you please clarify that this includes "mtNone"?

Good point!

-------------

PR: https://git.openjdk.java.net/jdk/pull/378


More information about the hotspot-dev mailing list