RFR: 8253183: Fragile memory barrier selection for some weak memory model platforms [v2]

Martin Doerr mdoerr at openjdk.java.net
Tue Sep 29 20:41:57 UTC 2020


On Tue, 29 Sep 2020 17:32:59 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename loadload_for_iriw to loadload_for_IRIW
>
> src/hotspot/share/runtime/synchronizer.cpp line 1111:
> 
>> 1109:         // dmw/header and _contentions may get written by different threads.
>> 1110:         // Make sure to observe them in the same order when having several observers.
>> 1111:         OrderAccess::loadload_for_iriw();
> 
> The code we're replacing using 'IRIW' instead of 'iriw'.

Makes sense. Renamed to upper case IRIW. Also removed unnecessary OrderAccess:: qualification inside of class
OrderAccess.

-------------

PR: https://git.openjdk.java.net/jdk/pull/387


More information about the hotspot-dev mailing list