RFR: 8253650: Cleanup: remove alignment_hint parameter from os::reserve_memory

Thomas Stuefe stuefe at openjdk.java.net
Wed Sep 30 12:02:27 UTC 2020


On Wed, 30 Sep 2020 10:58:05 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/os/posix/os_posix.cpp line 321:
>> 
>>> 319:     // For file mapping, we do not call os:reserve_memory() because
>>> 320:     // we need to deal with shrinking of the file space later when we release extra memory after alignment.
>>> 321:     // We also cannot called os:reserve_memory() with file_desc set to -1 because on aix we might get SHM memory.
>> 
>> Pre-existing: "Cannot called " =>  "Cannot call"
>
> and maybe os::reserve_memory() => os::reserve_memory_with_fd()

That comment is all over the place :)
I'll try to fix it up

-------------

PR: https://git.openjdk.java.net/jdk/pull/430


More information about the hotspot-dev mailing list