RFR: 8264538: Rename SystemDictionary::parse_stream [v2]

[Coleen Phillimore]

On 4/1/21 9:48 AM, Lois Foltan wrote:
> On Wed, 31 Mar 2021 21:22:39 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>
>>> src/hotspot/share/prims/jvm.cpp line 950:
>>>
>>>> 948:   InstanceKlass* ik = NULL;
>>>> 949:   if (!is_hidden) {
>>>> 950:     ClassLoadInfo cl_info(protection_domain);
>>> Minor comment, you could pull the creation of ClassLoadInfo out of this if statement since both the the if and the else sections create a ClassLoadInfo with pretty much the same information.
>> That other ClassLoadInfo cl_info(protection_domain) you see is from another function, so I can't pull it out.
>> The other side of the 'if' statement creates a ClassLoadInfo with all the hidden class goodies.
> In jvm_lookup_define_class there are 2 ClassLoadInfo cl_info constructions on line #950 and line #961 that could be pull out of the if statement.  Again comment is minor and I am ok with how you decide to go forward with it.

Sorry I didn't see this comment in the pull request, and thanks for 
explaining that the ClassLoadInfo from the 'else' clause could have been 
pulled out of the if statement.  I was thinking the one in the 'if' 
clause.  We can change it if we're in the area next time.

Thanks,
Coleen

>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/3289