RFR: 8264540: WhiteBox.metaspaceReserveAlignment should return shared region alignment [v2]

[Calvin Cheung]

On Thu, 1 Apr 2021 22:15:51 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Hi, Please review
>>   After JDK-8236847, the shared region alignment (new as MetaspaceShared::core_region_alignment) is no longer default to os pagesize, it is a configurable value at build time instead. The WhiteBox api metaspaceReserveAlignment() should reflect the change. 
>> 
>> Tests:tier1,tier2,tier3,tier4
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix minimal build failure

Looks good. Just one comment in one of the test changes.

test/hotspot/jtreg/runtime/cds/appcds/SharedRegionAlignmentTest.java line 38:

> 36:  * @run driver jdk.test.lib.helpers.ClassFileInstaller sun.hotspot.WhiteBox
> 37:  * @run driver jdk.test.lib.helpers.ClassFileInstaller -jar hello.jar Hello
> 38:  * @run main/othervm/timeout=240 -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbootclasspath/a:. SharedRegionAlignmentTest

Is the increase in timeout necessary?

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3309