RFR: 8264540: WhiteBox.metaspaceReserveAlignment should return shared region alignment [v2]

[Yumin Qi]

On Fri, 2 Apr 2021 16:45:39 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix minimal build failure
>
> test/hotspot/jtreg/runtime/cds/appcds/SharedRegionAlignmentTest.java line 75:
> 
>> 73:                                                  TestCommon.concat(dumpLP, logArg));
>> 74:             out.shouldContain("Dumping shared data to file");
>> 75:             boolean is_alignment_logged = out.getStdout().contains(regionAlignmentString + regionAlignment);
> 
> Is `is_alignment_logged` still needed? Now both dump time and run time should contain the `regionAlignmentString + regionAlignment` string. Also, I think it's better to use a local variable like:
> 
> String expectedAlignment = regionAlignmentString + regionAlignment;

Yes, it should be contained in both dump/runtime time, will remove it. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3309