RFR: 8254050: HotSpot Style Guide should permit using the "override" virtual specifier [v3]
Kim Barrett
kbarrett at openjdk.java.net
Sun Apr 4 04:26:25 UTC 2021
> Please review and vote on this change to the HotSpot Style Guide to permit
> the use of `override` virtual specifiers. The virtual specifiers `override`
> and `final` were added in C++11, and use of `final` is already permitted in
> HotSpot code.
>
> Using the `override` specifier provides error checking that the function is
> indeed overriding a virtual function declared in a base class. This can
> prevent some often surprisingly difficult to spot bugs.
>
> This is a modification of the Style Guide, so rough consensus among
> the HotSpot Group members is required to make this change. Only Group
> members should vote for approval (via the github PR), though reasoned
> objections or comments from anyone will be considered. A decision on
> this proposal will not be made before Tuesday 30-Mar-2021 at 12h00 UTC.
>
> Since we're piggybacking on github PRs here, please use the PR review
> process to approve (click on Review Changes > Approve), rather than
> sending a "vote: yes" email reply that would be normal for a CFV.
> Other responses can still use email of course.
Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
rebuild hotspot-style.html
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3021/files
- new: https://git.openjdk.java.net/jdk/pull/3021/files/375a916e..301a604d
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3021&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3021&range=01-02
Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/3021.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3021/head:pull/3021
PR: https://git.openjdk.java.net/jdk/pull/3021
More information about the hotspot-dev
mailing list