RFR: 8264711: More runtime TRAPS cleanups

[Lois Foltan]

On Mon, 5 Apr 2021 17:57:13 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this additional cleanup of use of TRAPS in hotspot runtime code.  The changes were tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64.
> 
> Thanks, Harold

Looks good Harold.  One minor comment for the file jfrJavaSupport.cpp.

Thanks,
Lois

src/hotspot/share/jfr/jni/jfrJavaSupport.cpp line 144:

> 142:   ObjectSynchronizer::jni_enter(h_obj, THREAD->as_Java_thread());
> 143:   ObjectSynchronizer::notifyall(h_obj, THREAD);
> 144:   ObjectSynchronizer::jni_exit(THREAD->as_Java_thread(), h_obj());

For consistency can you switch the parameter order for jni_enter as well in this change?  It looks a little bit odd that jni_exit was changed and not jni_enter.

-------------

Marked as reviewed by lfoltan (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3345