RFR: 8264748: Do not include arguments.hpp from compilerDefinitions.hpp

Tue Apr 6 19:08:29 UTC 2021

On Tue, 6 Apr 2021 07:27:36 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> compilerDefinitions.hpp is a popular header, included by 588 of about 1000 HotSpot .o files. It includes arguments.hpp only for a single function that's not used in critical paths.
> 
> After refactoring, the number of .o files that includes arguments.hpp reduces from 623 to 68.
> 
> (I also removed arguments.hpp from other files that don't actually need it.)

Nice!

How do you figure out where to remove the unneeded header and/or what to replace it with?

Do you use some tool to help you out with this?

-------------

Marked as reviewed by gziemski (Committer).

PR: https://git.openjdk.java.net/jdk/pull/3351