RFR: 8264748: Do not include arguments.hpp from compilerDefinitions.hpp

Ioi Lam iklam at openjdk.java.net
Wed Apr 7 05:41:26 UTC 2021


On Tue, 6 Apr 2021 19:54:03 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> compilerDefinitions.hpp is a popular header, included by 588 of about 1000 HotSpot .o files. It includes arguments.hpp only for a single function that's not used in critical paths.
>> 
>> After refactoring, the number of .o files that includes arguments.hpp reduces from 623 to 68.
>> 
>> (I also removed arguments.hpp from other files that don't actually need it.)
>
> Marked as reviewed by stefank (Reviewer).

Thanks @stefank and @gerard-ziemski for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3351


More information about the hotspot-dev mailing list