RFR: 8259242: Remove ProtectionDomainSet_lock [v3]
Coleen Phillimore
coleenp at openjdk.java.net
Thu Apr 8 23:09:49 UTC 2021
> This change makes the DictionaryEntry pd_set reads lock free, because when I set a low SafepointTimeout on the findDeadlock test, these threads were waiting on the ProtectionDomainSet_lock. This lock is a singleton that's taken for every dictionary entry.
>
> I don't know if this change will make the test never timeout again, because removing this lock caused us to hit a low SafepointTimeout on another _no_safepoint_check lock that is not so easy to eradictate.
>
> Tested with tiers 1-3. There's a test that exercises this code in runtime/Dictionary/ProtectionDomainCacheTest.java.
Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
Make ProtectionDomainEntry delete list global and set a threshold for deletions before handshaking. Fix if to when.
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3362/files
- new: https://git.openjdk.java.net/jdk/pull/3362/files/40c359b1..06624ed1
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3362&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3362&range=01-02
Stats: 24 lines in 3 files changed: 11 ins; 1 del; 12 mod
Patch: https://git.openjdk.java.net/jdk/pull/3362.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3362/head:pull/3362
PR: https://git.openjdk.java.net/jdk/pull/3362
More information about the hotspot-dev
mailing list