RFR: 8264868: Reduce inclusion of registerMap.hpp and register.hpp

David Holmes dholmes at openjdk.java.net
Fri Apr 9 04:59:07 UTC 2021


On Wed, 7 Apr 2021 21:03:10 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Register.hpp is included 815 times, and registerMap.hpp is include 862 times (out of about 1000 HotSpot .o files).
> 
> This can be reduced by refactoring the popular header file **frame.hpp**, so that it doesn't include registerMap.hpp anymore. This reduces the number of .o files that include register.hpp to 612, and that of registerMap.hpp to 109.
> 
> The total number of lines of C++ code compiled for HotSpot is reduced by about 0.5%.

Hi Ioi,

It isn't at all obvious to me how the stackFrameStream refactoring relates to the topic of this RFE. :)

But I don't see anything amiss, and if it improves build time etc, then it seems fine.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3384


More information about the hotspot-dev mailing list