RFR: 8264868: Reduce inclusion of registerMap.hpp and register.hpp

David Holmes david.holmes at oracle.com
Fri Apr 9 06:17:52 UTC 2021


On 9/04/2021 3:45 pm, Ioi Lam wrote:
> On Fri, 9 Apr 2021 04:56:32 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>> Hi Ioi,
>>
>> It isn't at all obvious to me how the stackFrameStream refactoring relates to the topic of this RFE. :)
>>
>> But I don't see anything amiss, and if it improves build time etc, then it seems fine.
>>
>> Thanks,
>> David
> 
> Thanks for the review!
> 
> `StackFrameStream` was the only thing in frame.hpp that needed to use `RegisterMap`. Since `StackFrameStream` is used by only 15 .o files, I moved it to its own header file. This makes possible to decouple frame.hpp with registerMap.hpp.

Ah! Got it.

Thanks,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/3384
> 


More information about the hotspot-dev mailing list