Integrated: 8259242: Remove ProtectionDomainSet_lock

Coleen Phillimore coleenp at openjdk.java.net
Fri Apr 9 15:02:29 UTC 2021


On Tue, 6 Apr 2021 18:54:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This change makes the DictionaryEntry pd_set reads lock free, because when I set a low SafepointTimeout on the findDeadlock test, these threads were waiting on the ProtectionDomainSet_lock.  This lock is a singleton that's taken for every dictionary entry.
> 
> I don't know if this change will make the test never timeout again, because removing this lock caused us to hit a low SafepointTimeout on another _no_safepoint_check lock that is not so easy to eradictate.
> 
> Tested with tiers 1-3.  There's a test that exercises this code in runtime/Dictionary/ProtectionDomainCacheTest.java.

This pull request has now been integrated.

Changeset: 06e6b1f7
Author:    Coleen Phillimore <coleenp at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/06e6b1f7
Stats:     162 lines in 10 files changed: 80 ins; 33 del; 49 mod

8259242: Remove ProtectionDomainSet_lock

Reviewed-by: dholmes, pchilanomate

-------------

PR: https://git.openjdk.java.net/jdk/pull/3362


More information about the hotspot-dev mailing list