RFR: 8265052: Break circular include dependency in objArrayOop.inline.hpp

David Holmes dholmes at openjdk.java.net
Mon Apr 12 09:34:41 UTC 2021


On Mon, 12 Apr 2021 08:09:00 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> There's a circular dependency of the includes in objArrayOop.inline.hpp. This does not show up in the current main line, but caused compilation errors in a JFR enhancement.
> 
> The objArrayOop.inline.hpp can't even be compiled by itself:
> 
> In file included from /home/stefank/git/alt2/open/src/hotspot/share/oops/access.inline.hpp:28,
>                  from /home/stefank/git/alt2/open/src/hotspot/share/oops/objArrayOop.inline.hpp:28:

Hi Stefan,

Fix seems fine. Though it seems  somewhat fortuitous that the inline functions used by this inline header file are actually declared in the non-inline version of the access header file. 

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3431


More information about the hotspot-dev mailing list