RFR: 8264940: java/lang/invoke/6998541/Test6998541.java failed "guarantee(ik->is_initialized()) failed: java/lang/Byte$ByteCache must be initialized" [v3]

Wang Huang whuang at openjdk.java.net
Tue Apr 13 02:35:22 UTC 2021


On Mon, 12 Apr 2021 17:55:47 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add missing header
>
> src/hotspot/share/opto/callGenerator.cpp line 595:
> 
>> 593:   return false;
>> 594: }
>> 595: 
> 
> The code is correct but, please, move this new code into ciInstanceKlass (near other `box` queries). The VM queries should be done in CI.
> 
> static bool is_box_cache_valid(CallNode* call) {
>   ciInstanceKlass* klass = call->as_CallStaticJava()->method()->holder();
>   return klass->is_box_cache_valid();
> }

I have cleaned these codes. Thank you for your review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3411


More information about the hotspot-dev mailing list