RFR: 8264940: java/lang/invoke/6998541/Test6998541.java failed "guarantee(ik->is_initialized()) failed: java/lang/Byte$ByteCache must be initialized" [v4]

[David Holmes]

On Tue, 13 Apr 2021 02:35:21 GMT, Wang Huang <whuang at openjdk.org> wrote:

>> *  The main reason is that in this situation the `BoxCache` is not initialized before `uncommon_trap`.
>> *  `java.lang.Byte$ByteCache` is loaded without initializing here 
>> * I think that all `*Cache` classes should be loaded in this situation.
>
> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refactor

Looks fine - just a missing include.

Thanks,
David

src/hotspot/share/ci/ciInstanceKlass.cpp line 287:

> 285: static bool is_klass_initialized(Symbol* klass_name) {
> 286:   VM_ENTRY_MARK;
> 287:   InstanceKlass* ik = SystemDictionary::find_instance_klass(klass_name, Handle(), Handle());

You need the #include for systemDictionary.hpp in this file now.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3411