RFR: 8262291: Refactor reserve_memory_special_huge_tlbfs [v6]

Stefan Johansson sjohanss at openjdk.java.net
Tue Apr 13 07:27:03 UTC 2021


On Mon, 12 Apr 2021 13:17:04 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Stefan Johansson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8262291-one-special-alloc
>>  - Thomas review.
>>    
>>    Changed commit_memory_special to return bool to signal if the request succeeded or not.
>>  - Self review.
>>    
>>    Update helper name to better match commit_memory_special().
>>  - Marcus review.
>>    
>>    Updated comments.
>>  - Ivan review
>>    
>>    Renamed helper to commit_memory_special and updated the comments.
>>  - 8262291: Refactor reserve_memory_special_huge_tlbfs
>
> Looks good to me.
> 
> Thanks, Thomas

Thanks @tstuefe, you have to actively approve the PR to make it ready for integration since you are the only Reviewer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3073


More information about the hotspot-dev mailing list