RFR: 8265323: Leftover local variables in PcDesc

Tobias Hartmann thartmann at openjdk.java.net
Fri Apr 16 08:11:40 UTC 2021


On Fri, 16 Apr 2021 03:16:30 GMT, Yi Yang <yyang at openjdk.org> wrote:

> Leftover local variables in PcDesc. Remove it to save electric power.

Marked as reviewed by thartmann (Reviewer).

src/hotspot/share/code/pcDesc.cpp line 46:

> 44: #ifndef PRODUCT
> 45:   ResourceMark rm;
> 46:   st->print_cr("PcDesc(pc=" PTR_FORMAT " offset=%x bits=%x):", p2i(real_pc(code)), pc_offset(), _flags);

This changes the output from

PcDesc(pc=0x00007fe00d12475f offset=ffffffff bits=0):
PcDesc(pc=0x00007fe00d12478c offset=2c bits=0):   Test::test3 at -1 (line 33)
``` 
to

PcDesc(pc=0x00007f4fc9035a5f offset=ffffffff bits=0):
PcDesc(pc=0x00007f4fc9035a8c offset=2c bits=0):
   Test::test3 at -1 (line 33)
``` 
But since that is more inline with the output of `ScopeDesc::print_on`, that's fine with me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3532


More information about the hotspot-dev mailing list