RFR: 8264372: Threads::destroy_vm only ever returns true [v2]

David Holmes dholmes at openjdk.java.net
Sun Apr 18 04:35:33 UTC 2021


On Fri, 16 Apr 2021 15:02:56 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjusted comment
>
> Thumbs up!
> 
> `// Don't bother changing state any more, VM is gone.`
> 
> would be a better comment.

Thanks @dcubed-ojdk  and @shipilev , I adjusted the comment to read:

// Don't bother restoring thread state, VM is gone.

Integrating now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3535


More information about the hotspot-dev mailing list