RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v2]
Christian Hagedorn
chagedorn at openjdk.java.net
Tue Apr 20 13:41:04 UTC 2021
On Mon, 19 Apr 2021 15:37:49 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> test/lib/jdk/test/lib/hotspot/ir_framework/AbstractInfo.java line 41:
>>
>>> 39: */
>>> 40: abstract public class AbstractInfo {
>>> 41: private static final Random random = new Random();
>>
>> you shouldn't use Random w/o predefined seed as it might make it harder to reproduce, please consider using `jdk.test.lib.Utils.getRandomInstance` or `jdk.test.lib.RandomFactory.getRandom` here
>
> I've also noticed that you use `Collections::shuffle` in `TestFrameworkExecution` w/o passing a reproducible rng.
Fixed that, too.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3508
More information about the hotspot-dev
mailing list