RFR: 8259316: [REDO] C1/C2 compiler support for blackholes [v2]

Aleksey Shipilev shade at openjdk.java.net
Thu Apr 22 10:43:41 UTC 2021


On Thu, 22 Apr 2021 10:39:45 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Good. Please, update copyright year in files you touched.
>
>> Good. Please, update copyright year in files you touched.
> 
> Thanks, only a few files needed updates to 2021.

> @shipilev , as your tests ignore external vm flags you should add `@requires vm.flagless` so we won't waste time on running them with different GC, JITs, etc.

Right. Added!
 
> to restore the balance in test descriptions, you might want to delete `@build compiler.blackhole.BlackholeTarget` as there is a statically detectable dependency b/w `compiler.blackhole.*Test` and `BlackholeTarget` hence jtreg/javac will build it while building `compiler.blackhole.*Test`

I don't think that's true... When I remove `@build` from those tests, they fail with missing `BlackholeTarget`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2024


More information about the hotspot-dev mailing list