RFR: 8265268: Unify ReservedSpace reservation code in initialize and try_reserve_heap [v2]

[Stefan Johansson]

On Thu, 22 Apr 2021 11:55:03 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Thomas and Ivan review
>
> src/hotspot/share/memory/virtualspace.cpp line 146:
> 
>> 144:   char* base;
>> 145:   // If the memory was requested at a particular address, use
>> 146:   // os::attempt_reserve_memory_at() to avoid over mapping something
> 
> "to avoid mapping over" - word order

Fixed.

> src/hotspot/share/memory/virtualspace.cpp line 147:
> 
>> 145:   // If the memory was requested at a particular address, use
>> 146:   // os::attempt_reserve_memory_at() to avoid over mapping something
>> 147:   // important.  If available space is not detected, return NULL.
> 
> "If available space is not detected" -> "If this (reservation) is unsuccessful...".
> 
> available space detected != reservation possible/successful

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3570