RFR: 8265268: Unify ReservedSpace reservation code in initialize and try_reserve_heap [v2]
Stefan Johansson
sjohanss at openjdk.java.net
Thu Apr 22 14:01:51 UTC 2021
On Thu, 22 Apr 2021 08:42:51 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:
>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Thomas and Ivan review
>
> src/hotspot/share/memory/virtualspace.cpp line 159:
>
>> 157: base = map_or_reserve_memory(size, fd, exec);
>> 158: // Check alignment constraints. This is only needed when there is
>> 159: // no requested address. If a requested address is used it must be
>
> "If a requested address is used it must be aligned." seems redundant here, as it is covered in the branch above, and the assert clearly states that.
Yes, I added the assert later on and that really made this redundant. Removed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3570
More information about the hotspot-dev
mailing list