RFR: 8265268: Unify ReservedSpace reservation code in initialize and try_reserve_heap [v2]

[Stefan Johansson]

On Thu, 22 Apr 2021 14:05:35 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Thomas and Ivan review
>
> src/hotspot/share/memory/virtualspace.cpp line 189:
> 
>> 187:    if (large_pages_requested()) {
>> 188:       log_debug(gc, heap, coops)("Reserve regular memory without large pages");
>> 189:     }
> 
> I think we should move this entire block to the caller.

I thought about this as well, but wanted to keep `reserve(...)` as "clean" as possible and this log-message is connected to reserving large pages which is handled in `reserve_memory_special(...)`. 

The strange thing is that this log is using the tag-set `gc, heap, coops` (pre-existing) which suggests that we could move it all the way out to `try_reserve_heap(...)`. The problem with doing that is that this log is used by the test: TestLargePageUseForAuxMemory for other mappings than the heap. It would most likely make sense to move this message to a different tag-set or possibly split it so that this log only is printed for the heap and we have a different one for other mappings. The sad part about that is that the log message and the "failure" becomes more separated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3570