RFR: 8265756: AArch64: initialize memory allocated for locals according to Windows AArch64 stack page growth requirement in template interpreter

Andrew Dinn adinn at openjdk.java.net
Fri Apr 23 11:52:32 UTC 2021


On Fri, 23 Apr 2021 11:20:50 GMT, Aleksei Voitylov <avoitylov at openjdk.org> wrote:

>> Can you please add comments to the new test explaining exactly what it is that the test is doing, why you need to use a jasm file etc. Also add an @bug tag to the test.
>> 
>> Thanks,
>> David
>
> @dholmes-ora @theRealAph thanks for your comments. Please check the updated version.

@voitylov The patch still looks good modulo one niggle I have with the comment.

You use the phrase "local variable table" (twice). That jarred when I read it because it's the term used for the debug mode bytecode attribute that records names and liveness ranges for parameter & local variables found in the java source. It would avoid any potential for confusion if you used a different term, e.g. "local vars stack region".

-------------

PR: https://git.openjdk.java.net/jdk/pull/3633


More information about the hotspot-dev mailing list