RFR: 8229517: Support for optional asynchronous/buffered logging [v9]

[Xin Liu]

On Thu, 25 Mar 2021 20:19:19 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix bugs/style/typo based on reviewers' feedbacks.
>>  - Accurate Decorations for AsyncLogging.
>>    
>>    A lightweight LogDecorationRef is created to keep LogDecorations at
>>    logging site. It uses refcnt to keep track multiple usage and
>>    automatically clean up. If no decorator is in use, no LogDecorationRef
>>    is created.
>
> src/hotspot/share/logging/logConfiguration.cpp line 544:
> 
>> 542:                                     " If set to 0, log rotation is disabled."
>> 543:                                     " This will cause existing log files to be overwritten.");
>> 544:   out->print_cr("   async=true|false - write asynchronously or not.");
> 
> Mention the default here which should be "false".

fixed.

> src/hotspot/share/logging/logDecorators.hpp line 89:
> 
>> 87:   }
>> 88: 
>> 89:   LogDecorators(const LogDecorators& o) : _decorators(o._decorators) {
> 
> Why do you need this new copy constructor?

I have removed it.

> src/hotspot/share/logging/logDecorators.hpp line 92:
> 
>> 90:   }
>> 91: 
>> 92:   LogDecorators& operator=(const LogDecorators& rhs) {
> 
> Why do you need this new assignment operator?

removed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3135