RFR: 8265491: Math Signum optimization for x86 [v7]
Marcus G K Williams
github.com+168222+mgkwill at openjdk.java.net
Sat Apr 24 00:21:50 UTC 2021
On Sat, 24 Apr 2021 00:08:19 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>> Marcus G K Williams has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Update DamonFool
>>
>> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>> - Refactor on suggestion of jatin-bhateja & theRealAph
>>
>> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>
> test/hotspot/jtreg/compiler/intrinsics/math/TestSignumIntrinsic.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>
> This is incorrect since it's not a new file.
>
> I suggest this kind of change
>
> diff --git a/test/hotspot/jtreg/compiler/intrinsics/math/TestSignumIntrinsic.java b/test/hotspot/jtreg/compiler/intrinsics/math/TestSignumIntrinsic.java
> index 86434d556bb..37aa511dcff 100644
> --- a/test/hotspot/jtreg/compiler/intrinsics/math/TestSignumIntrinsic.java
> +++ b/test/hotspot/jtreg/compiler/intrinsics/math/TestSignumIntrinsic.java
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved.
> * Copyright (c) 2020, BELLSOFT. All rights reserved.
> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> *
Thanks again @DamonFool. Fixed as you suggested.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3581
More information about the hotspot-dev
mailing list