RFR: 8255493: Support for pre-generated java.lang.invoke classes in CDS dynamic archive [v3]

[Yumin Qi]

On Tue, 27 Apr 2021 14:29:14 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move read static invoker lines to LambdaFormInokers, remove unneeded check for return  NULL
>
> src/hotspot/share/cds/lambdaFormInvokers.cpp line 86:
> 
>> 84:   guarantee(cds_klass != NULL, "jdk/internal/misc/CDS must exist!");
>> 85: 
>> 86:   log_info(cds)("Total lambdaform lines %d", _lambdaform_lines->length());
> 
> Can this logging be DEBUG level instead?

Thanks for review! Will move into DEBUG_ONLY

> src/hotspot/share/cds/lambdaFormInvokers.cpp line 125:
> 
>> 123:       log_info(cds)("Out of memory when reloading classes, quit");
>> 124:       return;
>> 125:     }
> 
> as_utf8_string doesn't return NULL for OOM.  If resource allocation fails in the lower levels, it'll vm_exit_out_of_memory.

Will delete the result check.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3611