RFR: 8255493: Support for pre-generated java.lang.invoke classes in CDS dynamic archive [v4]

Yumin Qi minqi at openjdk.java.net
Tue Apr 27 18:17:38 UTC 2021


On Tue, 27 Apr 2021 17:59:19 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved log invoker lines to debug only, removed check for as_utf8_string
>
> src/hotspot/share/cds/archiveBuilder.cpp line 263:
> 
>> 261:   log_info(cds)("    obj array classes  = %5d", _num_obj_array_klasses);
>> 262:   log_info(cds)("    type array classes = %5d", _num_type_array_klasses);
>> 263:   log_info(cds)("    symbols = %5d", _symbols->length());
> 
> Please align the '=' at line 263 with the line above.

Will reformat. Thanks.

> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestDynamicRegenerateHolderClasses.java line 26:
> 
>> 24: 
>> 25: /*
>> 26:  * @test
> 
> Please add a `@bug` line to this file.

Will update.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3611


More information about the hotspot-dev mailing list