RFR: 8265867: thread.hpp defines some enums but no reference [v2]

Xin Liu xliu at openjdk.java.net
Tue Apr 27 21:16:07 UTC 2021


On Tue, 27 Apr 2021 18:22:57 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Deleted 2 useless enums.
>> This patch also added const and constexpr for the applicable member functions.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert code change about "constness".

Thanks reviewers. 

I took a look at the building failure on macos. it should not be relevant to this patch. 
Linker editor can't resolve the symbol `__Copy_conjoint_words` on macos/arm64. 


2021-04-27T18:48:46.3842240Z Undefined symbols for architecture arm64:
2021-04-27T18:48:46.3873510Z   "__Copy_conjoint_words", referenced from:
2021-04-27T18:48:46.3894950Z       G1FullGCCompactTask::G1CompactRegionClosure::apply(oopDesc*) in g1FullGCCompactTask.o
2021-04-27T18:48:46.3931360Z       PSParallelCompact::decrement_destination_counts(ParCompactionManager*, PSParallelCompact::SpaceId, unsigned long, HeapWordImpl**) in psParallelCompact.o
2021-04-27T18:48:46.3950530Z       PSParallelCompact::copy_back(HeapWordImpl**, HeapWordImpl**) in psParallelCompact.o
2021-04-27T18:48:46.3997600Z       PSParallelCompact::fill_region(ParCompactionManager*, MoveAndUpdateClosure&, unsigned long) in psParallelCompact.o
2021-04-27T18:48:46.4034130Z       MoveAndUpdateClosure::copy_partial_obj() in psParallelCompact.o
2021-04-27T18:48:46.4052290Z       MoveAndUpdateClosure::copy_until_full() in psParallelCompact.o
2021-04-27T18:48:46.4101250Z       MoveAndUpdateClosure::do_addr(HeapWordImpl**, unsigned long) in psParallelCompact.o
2021-04-27T18:48:46.4137880Z       ...
...
2021-04-27T18:48:46.4792490Z ld: symbol(s) not found for architecture arm64
2021-04-27T18:48:46.4834120Z clang: error: linker command failed with exit code 1 (use -v to see invocation)
2021-04-27T18:48:46.4919160Z gmake[3]: *** [lib/CompileJvm.gmk:144: /Users/runner/work/jdk/jdk/jdk/build/macos-aarch64/support/modules_libs/java.base/server/libjvm.dylib] Error 1
2021-04-27T18:48:46.4920590Z gmake[3]: *** Waiting for unfinished jobs....
2021-04-27T18:48:46.7713910Z gmake[2]: *** [make/Main.gmk:255: hotspot-server-libs] Error 2

-------------

PR: https://git.openjdk.java.net/jdk/pull/3702


More information about the hotspot-dev mailing list