RFR: 8255493: Support for pre-generated java.lang.invoke classes in CDS dynamic archive [v8]
Yumin Qi
minqi at openjdk.java.net
Wed Apr 28 16:59:54 UTC 2021
On Tue, 27 Apr 2021 23:26:41 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Restore filemap.[ch]pp
>
> src/hotspot/share/cds/lambdaFormInvokers.cpp line 67:
>
>> 65: void LambdaFormInvokers::append_filtered(char* line) {
>> 66: for (int k = 0; k < NUM_FILTER; k++) {
>> 67: if (strstr(line, filter[k]) != nullptr) {
>
> Do you really want to match anywhere in the string? I'm assuming the line should start with the filter?
You reminded me that only the invoker lines which contain four holder class be stored in static archive, not else. I will change that part. For the filtered lines, it starts with [LF_RESOLVE] .... so the comparison I used here to check if the line contains "java.lang.invoke.<Class$holder>".
-------------
PR: https://git.openjdk.java.net/jdk/pull/3611
More information about the hotspot-dev
mailing list