RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v7]
Igor Ignatyev
iignatyev at openjdk.java.net
Fri Apr 30 19:15:02 UTC 2021
On Fri, 30 Apr 2021 18:22:16 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Fix XCOMP cases from old framework and turn it into new debug flag -DIgnoreCompilerControls
>> - Apply review comments: Added new Compiler annotation class for @DontCompile, changed C1 into C1_SIMPLE, refactored code for ExcludeRandom and FlipC1C2, added missing flag description in README, and some other smaller refactoring/renamings
>
> test/lib/jdk/test/lib/hotspot/ir_framework/TestInfo.java line 57:
>
>> 55: * allowing a compilation on the requested level in {@link Test#compLevel()}.
>> 56: *
>> 57: * @return {@code true} if the framework compiled the test;
>
> as in `RunInfo`:
> s/compiled/skipped compilation of/
btw, do we really need these methods in both `RunInfo` and `TestInfo`?
-------------
PR: https://git.openjdk.java.net/jdk/pull/3508
More information about the hotspot-dev
mailing list