RFR: 8263567: gtests don't terminate the VM safely

[David Holmes]

On Wed, 4 Aug 2021 07:05:26 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Please review this fix to shutdown cleanly any JVMs created by gtests that aren't aborted.
>> 
>> Testing:
>>   - manual instrumentation to check all JVM construction and then deletion during gtest runs
>>   - local gtest testing
>>   - tiers 1-3 gtest testing
>> 
>> Thanks,
>> David
>
> test/hotspot/gtest/gtestMain.cpp line 220:
> 
>> 218: 
>> 219: // This is generally run once for a set of tests, but if we have vm_assert, or other_vm
>> 220: // tests, a new process is forked and this will be called, for each of those tests.
> 
> is the comma needed?

Which one? :) I wanted to convey that the fork and execution of `runUnitTestsInner` is done for each test. I will reword and restructure.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4986