RFR: 8263567: gtests don't terminate the VM safely

[David Holmes]

On Wed, 4 Aug 2021 07:13:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Please review this fix to shutdown cleanly any JVMs created by gtests that aren't aborted.
>> 
>> Testing:
>>   - manual instrumentation to check all JVM construction and then deletion during gtest runs
>>   - local gtest testing
>>   - tiers 1-3 gtest testing
>> 
>> Thanks,
>> David
>
> test/hotspot/gtest/unittest.hpp line 99:
> 
>> 97:         fprintf(stderr, "Warning: DestroyJavaVM error %d\n", ret);  \
>> 98:       }                                                             \
>> 99:     }                                                               \
> 
> For better readibility I'd factor this out to an own function.

The problem is I don't have anywhere to put that function so that this macro can invoke it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4986