RFR: 8263567: gtests don't terminate the VM safely [v2]

[Thomas Stuefe]

On Fri, 6 Aug 2021 04:54:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this fix to shutdown cleanly any JVMs created by gtests that aren't aborted.
>> 
>> Testing:
>>   - manual instrumentation to check all JVM construction and then deletion during gtest runs
>>   - local gtest testing
>>   - tiers 1-3 gtest testing
>> 
>> Thanks,
>> David
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressed comments from @tstuefe

All good now. The fact that other_vm re-runs VM initialization tripped me off more than once btw :)

test/hotspot/gtest/gtestMain.cpp line 121:

> 119:   virtual void OnTestStart(const ::testing::TestInfo& test_info) {
> 120:     const char* name = test_info.name();
> 121:     if ( _jvm == nullptr && is_same_vm_test(name)) {

superfluous blank? (after first open bracket)

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4986