RFR: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError [v5]
Coleen Phillimore
coleenp at openjdk.java.net
Mon Aug 9 23:34:33 UTC 2021
On Mon, 9 Aug 2021 22:43:34 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix java.base/bootstrap class loader comment.
>
> Hi Coleen,
>
> Still thinking about the details of this. One concern below, and a few minor comments.
>
> Thanks,
> David
@dholmes-ora Thanks for looking at this in detail. It does a lot during initialization error so useful to be cautious. I was thinking of maybe having a diagnostic option to turn it off in case some application down the line finds it's doing too much or one that has a lot of initialization errors that blow up the table.
> src/hotspot/share/classfile/javaClasses.cpp line 2711:
>
>> 2709:
>> 2710: // If new exception returns a different exception while creating the exception, return null.
>> 2711: if (h_cause->klass()->name() != exception_name) {
>
> Some logging here to show that an exception occurred trying to do this would be useful I think.
ok. I should probably add back the table printing and logging. I made it resizeable but I don't think I'll ever have to resize it so didn't put the code for that.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4996
More information about the hotspot-dev
mailing list