RFR: 8271869: AArch64: build errors with GCC11 in frame::saved_oop_result

[Andrew Haley]

On 8/10/21 8:41 AM, Kim Barrett wrote:

> Yuck!  But I guess we don't have any other quick solution to
> supporting this compiler version, so as with JDK-8270083 I'm
> conditionally approving this as a temporary workaround.  I see this
> bug is already linked to JDK-8270140.
>
> @theRealAph - You mentioned a prototype patch to fix the register
> definitions (probably addressing JDK-8270140?).

Yes, it fixes that by making Register well-defined behaviour.

> How close are you on that?  Do you need any help?

The patch works just fine, but there is a smallish performance
degradation.  Having said that, the degradation is much less than the
performance gain from 8269122 (The use of "extern const" for Register
definitions generates poor code) so probably no-one would notice, and
we'd get rid of the undefined behaviour.  I didn't submit it because I
thought people rather liked the fake-pointer-to-nothing hack and
didn't care about UB. I can dig the patch out if you like.

--
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671