RFR: 8048190: NoClassDefFoundError omits original ExceptionInInitializerError [v8]

[Coleen Phillimore]

On Tue, 10 Aug 2021 03:43:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is a change to save the class initialization error stack trace in a hashtable and return it as the cause when NoClassDefFoundError is thrown.  The first commit is a more limited version of this that just changes the message, by adding to the message string.  The second commit is getting and saving the stack trace for the original exception, and using the thread in the message.  See CR for more details about how the message looks.
>> 
>> Tested with tier1-3 tests on 3 platforms.  Tier 4-6 in progress (all but two done and passed).
>
> Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - Make Hashtable a fixed size, not resizable and bigger.
>  - Merge branch 'master' into init-oom
>  - Throw EIIE with the original exception as the cause and stack trace. Much safer. Also remove the redundant test and not try to get OOM because that would make the test unreliable.
>  - Hooray another jasm file gone!
>  - Fix java.base/bootstrap class loader comment.
>  - Create new exception during initialization saving, so only need to save an oop. (Could potentially move to Doug's secret Class location.  If the exception is not bootstrap exception, throw EIIE instead with message of original exception.
>  - Merge branch 'master' into init-oom
>  - David review comments.
>  - Merge branch 'master' into init-oom
>  - 8048190: NoClassDefFoundError omits original ExceptionInInitializerError
>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/605c8a0e...ffec5bbd

Thanks for the review and additional suggestions.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4996