RFR: 8270489: Support archived heap objects in EpsilonGC [v2]
    Ioi Lam 
    iklam at openjdk.java.net
       
    Wed Aug 11 06:07:52 UTC 2021
    
    
  
On Tue, 10 Aug 2021 23:45:06 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @iignatev comments
>
> test/jtreg-ext/requires/VMProps.java line 303:
> 
>> 301:      * @param map - property-value pairs
>> 302:      */
>> 303:     protected void vmGCforCDS(SafeMap map) {
> 
> as this might impact any tests which use `vm.gc` and not just CDS tests, I think it would be better to first check if `vm.gc` is(will be) set to non-null value. given it's done by jtreg in another class and using another instance of Map, we can't just call `Map::contains` and have to check if GC has been explicitly selected by smth like `GC.selected().isSelectedErgonomically()`.
> 
> it also might be a good idea to comment at L#124 to indicate that this method overrides `vm.gc` value.
Thanks for the review. I've fixed it as you suggested.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5074
    
    
More information about the hotspot-dev
mailing list