RFR: 8270489: Support archived heap objects in EpsilonGC [v2]
Ioi Lam
iklam at openjdk.java.net
Mon Aug 16 04:16:49 UTC 2021
On Thu, 12 Aug 2021 09:29:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> I can't move `if (Metaspace::initialized())` into `EpsilonMonitoringSupport::update_counters()` because the code in this function also updates the global variable `_last_counter_update`.
>
> Yes, I understand that sacrifices the logging accuracy a bit: the `_last_counter_update` would include the initial CDS allocation. At the same time, I would not like to put `Metaspace::initialized()` checks on this (hot-when-not-TLAB) path, only to catch that initial allocation. So I suggest we add a boolean parameter like `allocate_work(size_t size, bool verbose)`, and call it with `false` from `allocate_loaded_archive_space`.
Fixed as you suggested in version 71c2aec.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5074
More information about the hotspot-dev
mailing list