RFR: 8270489: Support archived heap objects in EpsilonGC [v4]

Ioi Lam iklam at openjdk.java.net
Wed Aug 18 00:13:00 UTC 2021


On Mon, 16 Aug 2021 05:27:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - @shipilev review -- add verbose param to allocate_work()
>>  - Merge branch 'master' into 8270489-archived-heap-objects-for-epsilon-gc
>>  - @shipilev comments
>>  - @iignatev comments
>>  - fixed whitespaces
>>  - Add/update test cases
>>  - 8270489: Support archived heap objects in EpsilonGC
>
> src/hotspot/share/gc/epsilon/epsilonHeap.cpp line 268:
> 
>> 266: HeapWord* EpsilonHeap::allocate_loaded_archive_space(size_t size) {
>> 267:   // Cannot use verbose=true because Metaspace is not initialized
>> 268:   return allocate_work(size, /*verbose=*/false);
> 
> Suggestion:
> 
>   return allocate_work(size, /* verbose = */ false);

Fixed. Thanks for the review.

> src/hotspot/share/gc/epsilon/epsilonHeap.hpp line 91:
> 
>> 89: 
>> 90:   // Allocation
>> 91:   HeapWord* allocate_work(size_t size, bool verbose=true);
> 
> Suggestion:
> 
>   HeapWord* allocate_work(size_t size, bool verbose = true);

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5074


More information about the hotspot-dev mailing list