RFR: 8272723: Don't use Access API to access primitive fields [v2]
Erik Österlund
eosterlund at openjdk.java.net
Fri Aug 20 07:38:32 UTC 2021
On Fri, 20 Aug 2021 07:33:07 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:
>> src/hotspot/share/prims/unsafe.cpp line 233:
>>
>>> 231: T get_volatile() {
>>> 232: GuardUnsafeAccess guard(_thread);
>>> 233: volatile T ret = Atomic::load_acquire(addr());
>>
>> Is MO_SEQ_CST to load_acquire mapping correct?
>
> No it is not.
> Is MO_SEQ_CST to load_acquire mapping correct?
We should probably retain RawAccess<MO_SEQ_CST> here to get the right semantics.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5187
More information about the hotspot-dev
mailing list