RFR: 8221360: Eliminate Shared_DirtyCardQ_lock [v3]
Kim Barrett
kbarrett at openjdk.java.net
Tue Aug 24 13:09:54 UTC 2021
On Mon, 23 Aug 2021 12:15:37 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>>
>> helper function for re-enqueue
>
> src/hotspot/share/gc/g1/g1RemSet.cpp line 1699:
>
>> 1697: // enqueuing an entire buffer for just this card.
>> 1698: *card_ptr = G1CardTable::dirty_card_val();
>> 1699: G1DirtyCardQueueSet& dcqs = G1BarrierSet::dirty_card_queue_set();
>
> This is just a suggestion: maybe put this code block to put and enqueue that card into an extra buffer into an extra method. It does not seem to fit just here (i.e. all that gory details how to handle a buffer).
I split that out into new helper function enqueue_for_reprocessing.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5118
More information about the hotspot-dev
mailing list